Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrates GCE sdk from v0.beta to v1 #8972

Merged
merged 2 commits into from
Apr 24, 2020
Merged

Migrates GCE sdk from v0.beta to v1 #8972

merged 2 commits into from
Apr 24, 2020

Conversation

geojaz
Copy link
Member

@geojaz geojaz commented Apr 24, 2020

Waiting on #8969

Bumps the gcp libraries from v0beta to v1!
&compute.InstanceGroupManagersResizeAdvancedRequest is only available in the beta libraries. I've updated the IGM resize method to reflect the docs

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geojaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2020
@geojaz
Copy link
Member Author

geojaz commented Apr 24, 2020

/retest

@rifelpet
Copy link
Member

you may need to restart the travis jobs through their UI, if you're able to. i can't...

@geojaz
Copy link
Member Author

geojaz commented Apr 24, 2020

yeah it doesn't look like i have access to restart that one, is it easy to add access for me too? :)

@rifelpet
Copy link
Member

rifelpet commented Apr 24, 2020 •
edited
Loading

are you logged into travis? if you do that via your github account it may give you access to your own jobs and such. if you are already logged in and it still wont let you, i'm not sure how we can retry them other than pushing another commit :(

@rifelpet
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2020
@k8s-ci-robot k8s-ci-robot merged commit 94f8a54 into kubernetes:master Apr 24, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Apr 24, 2020
@geojaz geojaz deleted the gce/update_sdk branch April 24, 2020 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshbranham joshbranham Awaiting requested review from joshbranham

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@geojaz @k8s-ci-robot @rifelpet