Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to Debian 9 (Stretch) for Kubernetes 1.8, 1.9 and 1.10 #8977

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Default to Debian 9 (Stretch) for Kubernetes 1.8, 1.9 and 1.10 #8977

merged 1 commit into from
Apr 27, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Apr 25, 2020

Debian 8 (Jessie) are shutting down ahead of its soon to be EOL. As Kops still officially supports older versions of Kubernetes and images are already built it should use them by default.

Failing periodic e2e for 1.10:
https://testgrid.k8s.io/sig-cluster-lifecycle-kops#kops-aws-k8s-1.10

/cc @justinsb @rifelpet

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 25, 2020
olemarkus
olemarkus reviewed Apr 25, 2020
View reviewed changes
Copy link
Member

@olemarkus olemarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2020
@hakman
Copy link
Member Author

hakman commented Apr 25, 2020 

$ aws ec2 describe-images \
  --owners 383156758163 \
  --query 'sort_by(Images, &CreationDate)[*].[CreationDate,Name,ImageId]' \
  --filters "Name=name,Values=k8s-*-stretch**" \
  --region us-east-1 \
  --output table
Date Name Image
2018-08-17T03:06:06.000Z k8s-1.8-debian-stretch-amd64-hvm-ebs-2018-08-17 ami-050a5ee88521c50e4
2018-08-17T03:29:28.000Z k8s-1.9-debian-stretch-amd64-hvm-ebs-2018-08-17 ami-0fcafe93681421d1a
2018-08-17T04:08:43.000Z k8s-1.10-debian-stretch-amd64-hvm-ebs-2018-08-17 ami-0718f95f70da8f50e

This was referenced Apr 27, 2020
Merged
Merged
@rifelpet
Copy link
Member

we confirmed this fixes 1.10 (see the linked test-infra PRs and https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/e2e-kops-aws-k8s-1-10/1254882546416619520 )

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2020
@k8s-ci-robot k8s-ci-robot merged commit f00e538 into kubernetes:master Apr 27, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Apr 27, 2020
@hakman hakman deleted the stretch-image-1.10 branch April 30, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemarkus olemarkus olemarkus left review comments

@justinsb justinsb Awaiting requested review from justinsb

@rifelpet rifelpet Awaiting requested review from rifelpet

Assignees

@olemarkus olemarkus

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hakman @rifelpet @k8s-ci-robot @olemarkus