Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add af-south-1 and eu-south-1 regions (AWS) #9021

Merged
merged 3 commits into from
Apr 29, 2020

Conversation

moshevayner
Copy link
Member

@moshevayner moshevayner commented Apr 29, 2020

Fixes #9012

Just for clarification- the only changes I made were:

  1. Update upup/pkg/fi/cloud.go to include the new regions (AWS global infra doc shows they have 3 AZs so I assumed they would be 1a/b/c)
  2. Updated aws-sdk-go version to 1.30.6 in go.mod.

The rest of the changes are the result of running make gomod.

I ran make test and confirmed all the tests are passing.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 29, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @MoShitrit. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 29, 2020
@moshevayner
Copy link
Member Author

Not really sure why are the tests failing.
I just ran make nodeup examples test locally and confirmed that the exit code is 0.
Running on macOS 10.15.4. Not sure about the 1.13 version, though.
Would love to get some help on that please.

@hakman
Copy link
Member

hakman commented Apr 29, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 29, 2020
@hakman
Copy link
Member

hakman commented Apr 29, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2020
@rifelpet
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MoShitrit, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit e39ea8d into kubernetes:master Apr 29, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Apr 29, 2020
@moshevayner moshevayner deleted the issue-9012 branch April 29, 2020 12:27
k8s-ci-robot added a commit that referenced this pull request Apr 29, 2020
…9021-origin-release-1.17

Automated cherry pick of #8721: Upgrade AWS SDK #9021: Add af-south-1 and eu-south-1 regions to AWS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for new af-south-1 Africa (Cape Town) region
4 participants