Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature spotinst controller v1.0.58 #9022

Merged
merged 2 commits into from
May 3, 2020
Merged

Feature spotinst controller v1.0.58 #9022

merged 2 commits into from
May 3, 2020

Conversation

acaire
Copy link
Contributor

@acaire acaire commented Apr 29, 2020

This PR upgrades the Spotinst controller to version 1.0.58 and removes erroneous YAML separators

CC @liranp

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 29, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @acaire!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @acaire. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 29, 2020
@hakman
Copy link
Member

hakman commented Apr 29, 2020

/ok-to-test
/assign @liranp

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 29, 2020
@rifelpet
Copy link
Member

rifelpet commented May 3, 2020

can you run make kops-gobindata ? It looks like the CI jobs failing because of that.

acaire added 2 commits May 3, 2020 20:56
@acaire
style(spotinst): Remove erroneous YAML separators
eff2fe7 
This was causing the following error when applying the channel:

I0429 09:05:44.828460   15185 apply.go:71] configmap/spotinst-kubernetes-cluster-controller-config unchanged
secret/spotinst-kubernetes-cluster-controller-certs unchanged
serviceaccount/spotinst-kubernetes-cluster-controller unchanged
clusterrole.rbac.authorization.k8s.io/spotinst-kubernetes-cluster-controller unchanged
clusterrolebinding.rbac.authorization.k8s.io/spotinst-kubernetes-cluster-controller unchanged
deployment.apps/spotinst-kubernetes-cluster-controller configured
error: error validating "/tmp/channel152526040/manifest.yaml": error validating data: [apiVersion not set, kind not set]; if you choose to ignore these errors, turn validation off with --validate=false
Error: error updating "spotinst-kubernetes-cluster-controller.addons.k8s.io": error applying update from "s3://REDACTED/kops/REDACTED/addons/spotinst-kubernetes-cluster-controller.addons.k8s.io/v1.9.0.yaml": error running kubectl
@acaire
feature(spotinst): upgrade controller (v1.0.58)
d523a3d
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 3, 2020
@acaire
Copy link
Contributor Author

acaire commented May 3, 2020

fixed, thanks for the pointer @rifelpet :)

@rifelpet
Copy link
Member

rifelpet commented May 3, 2020

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acaire, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit 84687b8 into kubernetes:master May 3, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone May 3, 2020
@acaire acaire deleted the feature-spotinst-controller-v1.0.58 branch May 13, 2020 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshbranham joshbranham Awaiting requested review from joshbranham

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@rifelpet rifelpet

@liranp liranp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@acaire @k8s-ci-robot @hakman @rifelpet @liranp