Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename tests to make it easier to search for failing tests #9033

Merged
merged 1 commit into from
May 1, 2020

Conversation

rifelpet
Copy link
Member

@rifelpet rifelpet commented May 1, 2020

This is very minor...

GH Action's search functionality is not case sensitive.
In Travis CI, one could search for FAIL: and be taken to relevant test failures.
In GHA, these tests were also in the search results making it harder to find the actual tests that are failing.

This renames the tests so that searching for FAIL: (case insensitive) will only return failing tests.

Example:

Screen Shot 2020-04-30 at 9 09 02 PM

This is very minor...

GH Action's search functionality is not case sensitive.
In Travis CI, one could search for `FAIL:` and be taken to relevant test failures.
In GHA, these tests were also in the search results making it harder to find the actual tests that are failing.

This renames the tests so that searching for `FAIL:` (case insensitive) will only return failing tests
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 1, 2020
@hakman
Copy link
Member

hakman commented May 1, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 1, 2020
@k8s-ci-robot k8s-ci-robot merged commit 388d16a into kubernetes:master May 1, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone May 1, 2020
@rifelpet rifelpet deleted the test_fail_rename branch August 6, 2020 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants