-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update k8s.gcr.io/pause image to version 3.2 #9039
Conversation
@hakman we should probably update that to point to the new url, since I figured it's worth noting, since you're updating that now anyway. *** EDIT *** |
@MoShitrit I think they are still figuring out what to do. I think this will be a change mostly for those that push images there, not for us that pull it. In any case, best to change all at same time when will be the case. |
Makes sense. Sorry for raising a false flag! 😄 |
Did we want to specify |
/lgtm |
For now I want to make sure it is compatible with older versions of Docker. Removing the |
thats a lot of test references to a one line change :) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Probably the most popular container image in the world 🤣 |
It's been a long time since
pause
was last updated. Multi-arch support will require latest version for sure, but the signal handler to clean up orphaned zombie processes added in 3.1 will also be useful.https://github.com/kubernetes/kubernetes/blob/master/build/pause/CHANGELOG.md