Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s.gcr.io/pause image to version 3.2 #9039

Merged
merged 1 commit into from
May 2, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented May 1, 2020

It's been a long time since pause was last updated. Multi-arch support will require latest version for sure, but the signal handler to clean up orphaned zombie processes added in 3.1 will also be useful.
https://github.com/kubernetes/kubernetes/blob/master/build/pause/CHANGELOG.md

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 1, 2020
@moshevayner
Copy link
Member

moshevayner commented May 1, 2020

@hakman we should probably update that to point to the new url, since k8s.gcr.io is going away soon. https://groups.google.com/d/msg/kubernetes-dev/MkXnkTSJ_vs/7wvClbkxAgAJ

I figured it's worth noting, since you're updating that now anyway.

*** EDIT ***
Thinking again, I'm probably wrong. I'm not sure if pause actually falls under the criteria of k8s-artifacts-prod, does it?

@hakman
Copy link
Member Author

hakman commented May 2, 2020

@MoShitrit I think they are still figuring out what to do. I think this will be a change mostly for those that push images there, not for us that pull it. In any case, best to change all at same time when will be the case.

@moshevayner
Copy link
Member

Makes sense. Sorry for raising a false flag! 😄

@johngmyers
Copy link
Member

Did we want to specify pause instead of pause-amd64 in preparation for ARM support?

@johngmyers
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2020
@hakman
Copy link
Member Author

hakman commented May 2, 2020

Did we want to specify pause instead of pause-amd64 in preparation for ARM support?

For now I want to make sure it is compatible with older versions of Docker. Removing the -amd64 suffix is next on my todo list.

@rifelpet
Copy link
Member

rifelpet commented May 2, 2020

thats a lot of test references to a one line change :)
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2020
@k8s-ci-robot k8s-ci-robot merged commit d29253a into kubernetes:master May 2, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone May 2, 2020
@hakman
Copy link
Member Author

hakman commented May 2, 2020

thats a lot of test references to a one line change :)

Probably the most popular container image in the world 🤣

@hakman hakman deleted the pause-3.2 branch July 1, 2020 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants