Validate more static pods on masters #9049
Conversation
k8s-ci-robot
added
area/rolling-update
cncf-cla: yes
| var masterStaticPods = []string{ | ||
| "kube-apiserver", | ||
| "kube-controller-manager", | ||
| "kube-scheduler", |
There was a problem hiding this comment.
Just curious, do etcd-manager-* startic pods get checked also?
There was a problem hiding this comment.
No. If the cluster uses the legacy etcd provider there won't be any etcd-manager-* pods. Checking the cluster's spec would add a lot of complexity. I suspect the kube-apiserver pods won't be able to go into ready state without etcd pods.
There was a problem hiding this comment.
OK, probably not worth the trouble for now. Thanks.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
| delete(masterWithoutManager, nodeByAddress[pod.Status.HostIP]) | ||
| app := pod.GetLabels()["k8s-app"] | ||
| if pod.Namespace == "kube-system" && masterWithoutPod[nodeByAddress[pod.Status.HostIP]][app] { | ||
| delete(masterWithoutPod[nodeByAddress[pod.Status.HostIP]], app) |
There was a problem hiding this comment.
This does assume that all the pods are static pods; that's true I believe. I do wonder why we did it this way, it looks like spec.nodeName is populated on the pods when I checked.
|
Thanks @johngmyers - looks great. Not sure why we're not using spec.nodeName - maybe that is only populated in recent k8s versions? (Do you remember?) /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This should cut down on cluster validation flapping.
Not testing the etcd pods as their
k8s-appannotation depends on whether or not the cluster is configured to use etcd-manager. (It's also unlikely kube-apiserver would be ready without them.) Not testing kube-proxy pods because whether or not they're supposed to be there depends on the cluster spec.Suppressing the static pod checks on non-ready nodes to cut down on redundant failure messages.
/area rolling-update