Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instance_groups.md #9072

Merged
merged 2 commits into from
May 8, 2020
Merged

Update instance_groups.md #9072

merged 2 commits into from
May 8, 2020

Conversation

ranshn
Copy link
Contributor

@ranshn ranshn commented May 6, 2020

the description and link for spotAllocationStrategy are currently taken from the Spot Fleet documentation, while kops uses EC2 Auto Scaling groups. these are two different tools/APIs, so I am proposing a fix to the readme file that would correct spotAllocationStrategy to point to the ASG documentation instead.

the description and link for spotAllocationStrategy are currently taken from the Spot Fleet documentation, while kops uses EC2 Auto Scaling groups. these are two different tools/APIs, so I am proposing a fix to the readme file that would correct spotAllocationStrategy to point to the ASG documentation instead.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 6, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @ranshn!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @ranshn. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 6, 2020
@ranshn
Copy link
Contributor Author

ranshn commented May 6, 2020

assign @granular-ryanbonham

@mikesplain
Copy link
Contributor

Thanks @ranshn! This looks pretty good. Since you're in there, would you be up for adding an example of a complete mixedInstancePolicy config, as most of the other section have, so users can copy and paste and change each param? I don't have experience with them but I think that could be useful in addition to your cleanup.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 6, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 6, 2020
@ranshn
Copy link
Contributor Author

ranshn commented May 6, 2020

Thanks @ranshn! This looks pretty good. Since you're in there, would you be up for adding an example of a complete mixedInstancePolicy config, as most of the other section have, so users can copy and paste and change each param? I don't have experience with them but I think that could be useful in addition to your cleanup.

/ok-to-test

Done! let me know if this lgty or if you had something else in mind? maybe cut the non-mixedInstancePolicy parts out of the example?

@gjtempleton
Copy link
Member

/lgtm
I think it probably makes most sense for users getting started as a full useful stanza that'll launch a full blown instance group.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2020
@rifelpet
Copy link
Member

rifelpet commented May 8, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ranshn, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2020
@k8s-ci-robot k8s-ci-robot merged commit f1af197 into kubernetes:master May 8, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants