-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update instance_groups.md #9072
Conversation
the description and link for spotAllocationStrategy are currently taken from the Spot Fleet documentation, while kops uses EC2 Auto Scaling groups. these are two different tools/APIs, so I am proposing a fix to the readme file that would correct spotAllocationStrategy to point to the ASG documentation instead.
Welcome @ranshn! |
Hi @ranshn. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
assign @granular-ryanbonham |
Thanks @ranshn! This looks pretty good. Since you're in there, would you be up for adding an example of a complete /ok-to-test |
Done! let me know if this lgty or if you had something else in mind? maybe cut the non-mixedInstancePolicy parts out of the example? |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ranshn, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
the description and link for spotAllocationStrategy are currently taken from the Spot Fleet documentation, while kops uses EC2 Auto Scaling groups. these are two different tools/APIs, so I am proposing a fix to the readme file that would correct spotAllocationStrategy to point to the ASG documentation instead.