Spotinst: Allow users to disable the controller add-on

[liranp]

This PR adds a new feature flag, named SpotinstController, that allows users to toggle the installation of the Spotinst controller off. The feature flag defaults to true to maintain backward compatibility.

[rifelpet]

Out of curiosity, in what situations would a user want to disable the controller? If they want to run the controller themselves?

[liranp]

Exactly. We maintain a charts repository so users can install and manage the controller using its chart.

[rifelpet]

Got it, that makes sense.

Can we add the new FF to the docs? at least docs/advanced/experimental.md.

I'm noticing we don't have any docs on using the Spotinst provider, but adding that or at least a link to Spotinst docs elsewhere can always happen in a separate PR :)

[liranp]

Actually, I'm working on comprehensive documentation for the Spotinst provider, so I'll just add that to there and raise a separate PR really soon :)

[rifelpet]

sounds great!
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liranp, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rifelpet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rifelpet]

/retest

[liranp]

/retest