Fix port conflict on etcd-cilium vs dns-controller memberlist #9097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both were allocated port 3993; etcd-cilium is new and so it is less impactful to renumber that.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
size/XS
|
cc @olemarkus is it OK to renumber this? I know it's not great, but I think it's less risky that renumbering dns, as etcd-cilium is still new. (Or is there some reason I'm missing why we can share ports here?) |
|
Thanks @justinsb! /lgtm (used the wrong account at first) Marking as hold until you're ready |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
No problem at all to change the cilium etcd port |
|
Awesome, removing hold then. /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both were allocated port 3993; etcd-cilium is new and so it is less
impactful to renumber that.