Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CNI docs to their own files #9107

Merged
merged 2 commits into from
May 17, 2020

Conversation

olemarkus
Copy link
Member

The networking docs were getting a bit unruly.

Moved them to their own files and made them a little bit homogenic. Also removed the calico v3 upgrade docs that describes the process from before etcd-manager.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 10, 2020
@johngmyers
Copy link
Member

upgrade_from_kops_1.6_to_1.7_calico_cidr_migration.md is linked to from docs\releases\1.7-NOTES.md, which is why I submitted #8372.

@olemarkus
Copy link
Member Author

Yeah, I know I broke a link there. I don't think keeping the old release notes brings any value the way we maintain our docs. They offer no value now, or even worse, they can be very misleading. I had to actually create a calico cluster with an old version of kops and upgrade to see if those docs made sense at all.

docs/networking/lyft-vpc.md Outdated Show resolved Hide resolved
Co-authored-by: Ciprian Hacman <ciprianhacman@gmail.com>
@rifelpet
Copy link
Member

this looks great, thanks! We'll have to make a decision on what to do about broken links in docs specific to kops versions like release notes. k/k seems to keep around all of their old changelogs including broken links (for example the Documentation link here) if that is of any influence.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit f96099c into kubernetes:master May 17, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone May 17, 2020
@olemarkus olemarkus deleted the docs-networking-split branch June 3, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants