Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding most recent version of kube-state-metrics - 1.9.5 #9125

Merged
merged 1 commit into from
May 13, 2020

Conversation

moshevayner
Copy link
Member

Fixes #6474

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 13, 2020
@moshevayner
Copy link
Member Author

/assign @geojaz

@hakman
Copy link
Member

hakman commented May 13, 2020

@MoShitrit nice to see some updates in this area :).
Should you keep the same indentation as in the original manifests? I think the editor automatically indents sequence values in your case and usually this is not the expected style in kubernetes manifests.

@moshevayner
Copy link
Member Author

Thanks, @hakman !
Hmm, I actually just copied and pasted the manifests from their master repo, but given that I did it with my IDE, it might've done that indentation automatically for me.
Let me double check that!

@moshevayner
Copy link
Member Author

Yep, that was my IDE! 🤦
I'll amend my commit and force push with the correct indentation.
Thanks for pointing that out @hakman !

@moshevayner
Copy link
Member Author

/test pull-kops-e2e-kubernetes-aws

@hakman
Copy link
Member

hakman commented May 13, 2020

No worries. Happened to me also a few months ago 😁
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2020
@rifelpet
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MoShitrit, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit ee6a80c into kubernetes:master May 13, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone May 13, 2020
@moshevayner moshevayner deleted the fix-6474 branch May 13, 2020 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kube-state-metrics addon uses wrong API version for CronJobs
5 participants