Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Classic networking from docs #9142

Merged
merged 1 commit into from
May 19, 2020

Conversation

johngmyers
Copy link
Member

@johngmyers johngmyers commented May 19, 2020

Classic networking support was dropped as of Kubernetes 1.4.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 19, 2020
@k8s-ci-robot k8s-ci-robot added area/documentation size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 19, 2020
@hakman
Copy link
Member

hakman commented May 19, 2020

Cleanup is nice! The code related to classic networking should also be removed soon.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2020
@rifelpet
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2020
@hakman
Copy link
Member

hakman commented May 19, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 7aa65d7 into kubernetes:master May 19, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone May 19, 2020
@johngmyers johngmyers deleted the remove-classic branch May 19, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants