Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove loader support for nodeup tasks not used in models #9170

Merged
merged 1 commit into from
May 27, 2020

Conversation

johngmyers
Copy link
Member

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 24, 2020
@k8s-ci-robot k8s-ci-robot added area/nodeup size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 24, 2020
@justinsb
Copy link
Member

I'm surprised this one isn't used; I'm going to dig into why it isn't / where it came from.

On removing the serialization, I do think it's a good idea to clean up the custom deserialization. I do have a longer term idea that we should put less logic into nodeup, and pass it more of these tasks (as I think the logic in nodeup is much more opaque, harder to understand, harder to change). But I don't think that is incompatible with removing the "legacy" deserialization. (And we should just rely on yaml/json deserialization if we start passing raw tasks, IMO)

@justinsb
Copy link
Member

Yup, you're right ... unused legacy code. Thanks @johngmyers!

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 27, 2020
@johngmyers
Copy link
Member Author

I find tasks in Go code to be easier to understand and change than those in YAML. My IDE can cross-reference the Go code.

@johngmyers
Copy link
Member Author

/retest

1 similar comment
@johngmyers
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit fc48d06 into kubernetes:master May 27, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone May 27, 2020
@johngmyers johngmyers deleted the cleanup-nodetasks branch May 27, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants