Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use debian as default image for DO images #9181

Merged
merged 2 commits into from
May 27, 2020

Conversation

srikiz
Copy link
Contributor

@srikiz srikiz commented May 26, 2020

Since coreOS will no longer be supported, changing the DO image default to Debian instead.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 26, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @srikiz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 26, 2020
@hakman
Copy link
Member

hakman commented May 26, 2020

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 26, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2020
@rifelpet
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet, srikiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2020
@rifelpet
Copy link
Member

ugh there was an issue with the netlify jobs so prow won't merge the PR. I don't have permission to retry the jobs, but you could amend the commit and force push it to trigger a new set of jobs that would hopefully succeed.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

2 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@hakman
Copy link
Member

hakman commented May 27, 2020

Canceling LGTM until netlify is fixed.
/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2020
@johngmyers
Copy link
Member

Should also update the references to CoreOS in docs/getting_started/digitalocean.md

@srikiz
Copy link
Contributor Author

srikiz commented May 27, 2020

Thanks for mentioning this @johngmyers - updated DO docs now.

@hakman
Copy link
Member

hakman commented May 27, 2020

@srikiz should this be part of 1.17?
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2020
@k8s-ci-robot k8s-ci-robot merged commit a2a5e3d into kubernetes:master May 27, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone May 27, 2020
@srikiz
Copy link
Contributor Author

srikiz commented May 27, 2020

@hakman - Yes, I'll create a cherry-pick PR sometime today. Thanks !
When is 1.17 getting freezed?

@hakman
Copy link
Member

hakman commented May 27, 2020

1.17 is being prepared for release, but this seems pretty important and simple change.
Maybe you can also cherry-pick #9179 and hope that gets accepted also.
Thanks!

k8s-ci-robot added a commit that referenced this pull request May 28, 2020
…pstream-release-1.17

Automated cherry pick of #9181: Use debian as default image for DO images
@srikiz srikiz deleted the DO-useDebian-Image branch October 25, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants