Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gjtempleton as reviewer #9183

Merged
merged 1 commit into from
May 27, 2020

Conversation

johngmyers
Copy link
Member

@gjtempleton has been active in reviewing and authorship and meets the requirements for being a kops reviewer.

/cc @gjtempleton

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 27, 2020
@gjtempleton
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2020
@hakman
Copy link
Member

hakman commented May 27, 2020

Sounds like a great idea. +1 from me also. Welcome :).

@rifelpet
Copy link
Member

/lgtm
Welcome!

(Waiting for input from others before approval)

@justinsb
Copy link
Member

Big +1 from me - thanks for everything you already do @gjtempleton!

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2020
@hakman
Copy link
Member

hakman commented May 27, 2020

/retest

1 similar comment
@gjtempleton
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 6b1910f into kubernetes:master May 27, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone May 27, 2020
@johngmyers johngmyers deleted the gjtempleton-reviewer branch May 27, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants