Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nits for removal of S3 file versions #9188

Merged
merged 1 commit into from
May 28, 2020
Merged

Fix nits for removal of S3 file versions #9188

merged 1 commit into from
May 28, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented May 27, 2020

@justinsb noticed a few minor issues with #9171.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 27, 2020
@hakman hakman mentioned this pull request May 27, 2020
Merged
@hakman
Copy link
Member Author

hakman commented May 27, 2020

/cc @rifelpet

johngmyers
johngmyers reviewed May 28, 2020
View reviewed changes
Copy link
Member

@johngmyers johngmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits on the nits.
/lgtm

util/pkg/vfs/s3fs.go Outdated Show resolved Hide resolved
util/pkg/vfs/vfs.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2020
@johngmyers
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2020
@hakman hakman requested a review from johngmyers May 28, 2020 03:55
@johngmyers
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2020
@rifelpet
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2020
@k8s-ci-robot k8s-ci-robot merged commit 60b8f81 into kubernetes:master May 28, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone May 28, 2020
@hakman hakman deleted the remove-s3-versions-nits branch May 28, 2020 04:26
This was referenced May 28, 2020
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request May 29, 2020
@k8s-ci-robot
Merge pull request #9194 from hakman/automated-cherry-pick-of-#9171-#…
ff5ebf9 
…9188-upstream-release-1.17

Automated cherry pick of #9171: Remove all versions of a file form the S3 bucket #9188: Fix nits for removal of S3 file versions
k8s-ci-robot added a commit that referenced this pull request May 29, 2020
@k8s-ci-robot
Merge pull request #9195 from hakman/automated-cherry-pick-of-#9171-#…
348cc87 
…9188-upstream-release-1.16

Automated cherry pick of #9171: Remove all versions of a file form the S3 bucket #9188: Fix nits for removal of S3 file versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikesplain mikesplain Awaiting requested review from mikesplain

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

@rifelpet rifelpet Awaiting requested review from rifelpet

@johngmyers johngmyers Awaiting requested review from johngmyers

Assignees

@johngmyers johngmyers

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hakman @johngmyers @rifelpet @k8s-ci-robot