Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bazel rules for Docker to v0.14.2 #9196

Merged
merged 1 commit into from
May 28, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented May 28, 2020

This version contains a fix required for multi architecture support when creating container images:
https://github.com/bazelbuild/rules_docker/releases/tag/v0.14.2

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 28, 2020
@hakman hakman marked this pull request as draft May 28, 2020 08:08
@hakman hakman marked this pull request as ready for review May 28, 2020 10:22
@hakman
Copy link
Member Author

hakman commented May 28, 2020

/cc @rifelpet

@hakman hakman closed this May 28, 2020
@hakman hakman reopened this May 28, 2020
WORKSPACE Show resolved Hide resolved
@hakman hakman requested a review from rifelpet May 28, 2020 12:06
@rifelpet
Copy link
Member

travis might be stuck :(

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2020
@hakman
Copy link
Member Author

hakman commented May 28, 2020

Yup, noticed in a few PRs...
Nothing on https://www.traviscistatus.com though.

@k8s-ci-robot k8s-ci-robot merged commit 9a87998 into kubernetes:master May 28, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone May 28, 2020
@hakman hakman deleted the bazel-docker branch May 28, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants