Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repo packages not being installed #9203

Merged
merged 1 commit into from
May 29, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented May 29, 2020

I think the refactoring of package.go in 6b011c0 introduced a bug that keeps repo packages from being installed.

From https://storage.googleapis.com/kubernetes-jenkins/logs/e2e-kops-aws-k8s-latest/1266103273169883138/artifacts/54.249.221.142/kops-configuration.log

I0528 20:27:01.652991     836 package.go:299] Installing package "chrony" (dependencies: [])
I0528 20:27:01.653018     836 package.go:355] running command [apt-get install --yes --no-install-recommends]
I0528 20:48:51.349091    6615 executor.go:103] Tasks: 64 done / 65 total; 1 can run
I0528 20:48:51.349125    6615 executor.go:174] Executing task "Service/chrony": Service: chrony
I0528 20:48:51.349177    6615 changes.go:81] Field changed "Running" actual="false" expected="true"
I0528 20:48:51.349187    6615 changes.go:81] Field changed "Enabled" actual="<nil>" expected="true"
I0528 20:48:51.349196    6615 changes.go:81] Field changed "ManageState" actual="<nil>" expected="true"
I0528 20:48:51.349205    6615 changes.go:81] Field changed "SmartRestart" actual="<nil>" expected="true"
I0528 20:48:51.349268    6615 service.go:329] Restarting service "chrony"
W0528 20:48:51.353398    6615 executor.go:128] error running task "Service/chrony" (9m58s remaining to succeed): error doing systemd restart chrony: exit status 5
Output: Failed to restart chrony.service: Unit chrony.service not found.
I0528 20:48:51.353418    6615 executor.go:143] No progress made, sleeping before retrying 1 failed task(s)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 29, 2020
@hakman
Copy link
Member Author

hakman commented May 29, 2020

/cc @rifelpet @johngmyers

@johngmyers
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2020
@johngmyers
Copy link
Member

Sorry about that, Chief.

@hakman
Copy link
Member Author

hakman commented May 29, 2020

No worries, happens.

@rifelpet
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit aa6e09c into kubernetes:master May 29, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone May 29, 2020
@hakman hakman deleted the fix-repo-pkgs branch June 2, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants