Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update adding_a_feature.md with more modern example #9208

Merged
merged 2 commits into from
May 30, 2020

Conversation

johngmyers
Copy link
Member

Move away from nodeup model files. This one is light on testing and the history is a bit revisionist, but there weren't a lot of examples that touched api, validation, and nodeup.

/cc @olemarkus

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/api area/documentation area/nodeup size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 29, 2020
@olemarkus
Copy link
Member

I think it is a huge improvement over what was already there. And an extra test to boot!

At some point we need to tie some of those development pages more together. E.g with testing.md.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2020
@johngmyers
Copy link
Member Author

Unfortunately, API validation tests have about the least value to effort. They test internal APIs and fail to test the description of the error messages.

It probably would be worthwhile to add an integration test for ENI mode and document the process.

Is there a good way to test nodeup model code other than the e2e testgrid?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2020
@granular-ryanbonham
Copy link
Contributor

/lgtm Thanks for adding link to the api update docs.. I am not sure of a better way to test nodeup model code.

@granular-ryanbonham
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2020
@rifelpet
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2020
@k8s-ci-robot k8s-ci-robot merged commit f44d0dd into kubernetes:master May 30, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone May 30, 2020
@johngmyers johngmyers deleted the update-feature-doc branch May 30, 2020 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/documentation area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants