Upgrde amazon vpc cni to 1.6.2 #9214
Conversation
k8s-ci-robot
added
cncf-cla: yes
| @@ -3926,15 +3926,15 @@ spec: | |||
| requiredDuringSchedulingIgnoredDuringExecution: | |||
| nodeSelectorTerms: | |||
| - matchExpressions: | |||
| - key: "beta.kubernetes.io/os" | |||
| - key: "kubernetes.io/os" | |||
There was a problem hiding this comment.
I don't think we want to do this just yet as we are only just removing support for k8s 1.9 as of the 1.18 release, and these stable labels were only added as of k8s 1.14.
Looks like we'll need to fix it and all the other uses through the codebase of the beta labels before 1.19 though: kubernetes/kubernetes#91046
There was a problem hiding this comment.
@gjtempleton This change is applied only to the 1.16+ template, so should be ok.
There was a problem hiding this comment.
Yep, I’m not planning to backport it to earlier versions since it doesn’t seem to contain any critical fixes, just slight improvements. So if we merge it today it’ll probably go to 1.18 which should be fine.
|
/assign @geojaz |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MoShitrit, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Two changes in this PR: