Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packages hashes verification for containerd and Docker #9234

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Jun 1, 2020

Prow should verify package hashes for containerd and Docker.
Reference: #9215 (comment)

/cc @rifelpet

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 1, 2020
@olemarkus
Copy link
Member

Nice!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2020
@rifelpet
Copy link
Member

rifelpet commented Jun 1, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2020
@k8s-ci-robot k8s-ci-robot merged commit 118643e into kubernetes:master Jun 1, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jun 1, 2020
@rifelpet
Copy link
Member

rifelpet commented Jun 1, 2020

it looks like it worked:

https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/kops/9235/pull-kops-verify-hashes/1267438545979576320

based on the prow docs i'm wondering if we could remove optional: true on the job and set run_if_changed: nodeup/pkg/model/.* ? that way it would always run if there are changes to that package

I think we'd also want skip_report: false to make it a blocking job if it is run for a PR, which is what these docs indicate.

@hakman hakman deleted the verify-hashes branch June 2, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants