Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't build site when docs are unchanged #9235

Merged
merged 2 commits into from
Jun 1, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Jun 1, 2020

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 1, 2020
@hakman
Copy link
Member Author

hakman commented Jun 1, 2020

I did some quick tests and seems to work as expected.

10:38:54 AM: Build ready to start
10:38:56 AM: build-image version: 30f629161c0736b1a3ecd8b418e5eeffab5c0faf
10:38:56 AM: build-image tag: v3.3.14
10:38:56 AM: buildbot version: 578c7628507b646d2c2478c57933187c689f36ec
10:38:57 AM: Fetching cached dependencies
10:38:58 AM: Starting to download cache of 479.5MB
10:38:59 AM: Finished downloading cache in 1.648867276s
10:38:59 AM: Starting to extract cache
10:39:14 AM: Finished extracting cache in 14.785719038s
10:39:14 AM: Finished fetching cache in 16.578033794s
10:39:14 AM: Starting to prepare the repo for build
10:39:15 AM: Preparing Git Reference pull/9235/head
10:39:23 AM: Detected ignore command in Netlify configuration file. Proceeding with the specified command: 'git diff --quiet HEAD^ HEAD docs/'
10:39:23 AM: User-specified ignore command returned exit code 0. Returning early from build.
10:39:23 AM: Failed during stage 'checking build content for changes': Canceled build due to no content change
10:39:24 AM: Finished processing build request in 27.338024528s

@rifelpet
Copy link
Member

rifelpet commented Jun 1, 2020

there might be changes outside of docs/ that we'd want to trigger a netlify build:

  • netlify.toml
  • Makefile
  • mkdocs.yml
  • images/mkdocs/

Any chance we can include those in the ignore condition?

@rifelpet
Copy link
Member

rifelpet commented Jun 1, 2020

hijacking your PR to test your verify-hashes job :)

/test pull-kops-verify-hashes

@moshevayner
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2020
@rifelpet
Copy link
Member

rifelpet commented Jun 1, 2020

this PR does now build the docs site since it changes netlify.toml, so I think this is good to merge now 👍 thanks!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2020
@moshevayner
Copy link
Member

/retest

1 similar comment
@hakman
Copy link
Member Author

hakman commented Jun 1, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 5c92064 into kubernetes:master Jun 1, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jun 1, 2020
@hakman hakman deleted the netlify-ignore-unchanged branch June 2, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants