Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs helptext #9333

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Docs helptext #9333

merged 1 commit into from
Jun 11, 2020

Conversation

olemarkus
Copy link
Member

  • Add --wait to most kops validate cluster examples. Some confusion there because the help text is reused as well. See Kops --wait #1517
  • Ubuntu instead of Debian since I was in the neighbourhood

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 11, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 11, 2020
@gjtempleton
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2020
@olemarkus
Copy link
Member Author

/assign @KashifSaadat

mikesplain
mikesplain approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@mikesplain mikesplain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks @olemarkus!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikesplain, olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit 2ce351f into kubernetes:master Jun 11, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 11, 2020
@agilgur5 agilgur5 mentioned this pull request Jun 11, 2020
Closed
@hakman hakman mentioned this pull request Jul 23, 2020
Merged
k8s-ci-robot added a commit that referenced this pull request Jul 23, 2020
@k8s-ci-robot
Merge pull request #9613 from hakman/automated-cherry-pick-of-#9333-u…
25228c1 
…pstream-release-1.18

Automated cherry pick of #9333: Update cmd help text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikesplain mikesplain mikesplain approved these changes

@gjtempleton gjtempleton Awaiting requested review from gjtempleton

Assignees

@mikesplain mikesplain

@gjtempleton gjtempleton

@KashifSaadat KashifSaadat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@olemarkus @gjtempleton @k8s-ci-robot @mikesplain @KashifSaadat