Bug: Explicitly set default StorageClass to support upgrades

[joshbranham]

Dropping the annotation versus setting it to false breaks cluster upgrades.

Set the old gp2 StorageClass explicitly not the default

Fixes #9336

[joshbranham]

/test pull-kops-bazel-test

[johngmyers]

/kind bug
/lgtm

[hakman]

Any thoughts on using storageclass.kubernetes.io/is-default-class instead of the beta version?

[joshbranham]

Does 1.17 honor that annotation as well?

[hakman]

The beta one seems deprecated since 1.6:
kubernetes/kubernetes#40088

[joshbranham]

The beta one seems deprecated since 1.6:
kubernetes/kubernetes#40088

Yeah we can change the kops-ssd-1-17 to use the non-beta label but we will need to use the beta label (and maybe if we want the non-beta) on the gp2 in order to have the desired behavior.

Otherwise, we go back to the original point of how to make upgrades work on immutable fields, where if we just made gp2 have these updated settings alongside a breaking change of you have to run this with --force to upgrade 🤷

[johngmyers]

Since we've released 1.17.0, I don't think we can change the name of the annotation. Otherwise clusters updated with 1.17.0 will encounter this bug when we need to make kops-ssd-1-17 non-default.

[joshbranham]

So I think the only other thing would be to maybe just add some wording to release notes in case someone runs into a conflict on upgrade, its easy enough and zero risk to fix themselves. We can even provide a few one-liners. Thoughts?

[olemarkus]

+1 from me!

[hakman]

+1 from me also

[johngmyers]

Ah, that release note commit was added; not a replacement for the first one.
/lgtm

[rifelpet]

I agree that this sounds good to me. We can get this merged now to get it under e2e test coverage, and open a cherry-pick to release-1.17.
I presume we wont have a 1.17.1 release before office hours on friday, so we can take any final feedback there.

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joshbranham, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rifelpet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment