Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cilium to 1.7.5 #9367

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

olemarkus
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jun 15, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 15, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 15, 2020
Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2020
@rifelpet
Copy link
Member

is there a reason this is targeting release-1.18 and not master? I don't see this change in master nor an open PR for it.

@olemarkus
Copy link
Member Author

I am redoing the templates and config on master. See #9295 etc. Aim to use the 1.8 line on master if cilium release it in time (they are in RC phase now)

@rifelpet
Copy link
Member

ahh got it, thanks for the clarification.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2020
@rifelpet
Copy link
Member

though unfortunately we wont have much test coverage of this since the cilium periodic job(s) use the master branch...

@olemarkus
Copy link
Member Author

@rifelpet Wouldn't this do? https://testgrid.k8s.io/kops-k8s-1.18#kops-grid-cilium-u2004-k18
doesn't run that frequent though.

@olemarkus
Copy link
Member Author

Or they perhaps uses kops master, but that specific release branch?

@hakman
Copy link
Member

hakman commented Jun 15, 2020

Or they perhaps uses kops master, but that specific release branch?

👍

@hakman
Copy link
Member

hakman commented Jun 15, 2020

@rifelpet should we create optional e2e tests for the popular CNIs that we could run on any PR manually?

@rifelpet
Copy link
Member

Ah i like that idea a lot. we could even have them run automatically based on changes to each provider's yaml directory.

@hakman
Copy link
Member

hakman commented Jun 15, 2020

Right, that hashes test should be a pretty good template for this.
I think could run just on master, but would be better than nothing.

@rifelpet
Copy link
Member

anyone want to volunteer setting those up? We might be able to use them across multiple branches (master and release-*) too.

@hakman
Copy link
Member

hakman commented Jun 15, 2020

Let's start with master. I think I may have some time tomorrow to copy / paste these jobs, unless someone else beats me to it.

@k8s-ci-robot k8s-ci-robot merged commit bf8f260 into kubernetes:release-1.18 Jun 15, 2020
k8s-ci-robot added a commit that referenced this pull request Jun 15, 2020
…7-origin-release-1.17

Automated cherry pick of #9367: Bump cilium to 1.7.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants