-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump cilium to 1.7.5 #9367
Bump cilium to 1.7.5 #9367
Conversation
446c3dd
to
b287079
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
is there a reason this is targeting release-1.18 and not master? I don't see this change in master nor an open PR for it. |
I am redoing the templates and config on master. See #9295 etc. Aim to use the 1.8 line on master if cilium release it in time (they are in RC phase now) |
ahh got it, thanks for the clarification. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
though unfortunately we wont have much test coverage of this since the cilium periodic job(s) use the master branch... |
@rifelpet Wouldn't this do? https://testgrid.k8s.io/kops-k8s-1.18#kops-grid-cilium-u2004-k18 |
Or they perhaps uses kops master, but that specific release branch? |
👍 |
@rifelpet should we create optional e2e tests for the popular CNIs that we could run on any PR manually? |
Ah i like that idea a lot. we could even have them run automatically based on changes to each provider's yaml directory. |
Right, that hashes test should be a pretty good template for this. |
anyone want to volunteer setting those up? We might be able to use them across multiple branches (master and release-*) too. |
Let's start with master. I think I may have some time tomorrow to copy / paste these jobs, unless someone else beats me to it. |
…7-origin-release-1.17 Automated cherry pick of #9367: Bump cilium to 1.7.5
No description provided.