-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for c5a aws ec2 instance types #9386
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @coolstang! |
Hi @coolstang. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
d562610
to
5b6c46c
Compare
/ok-to-test |
How did a vendored file get updated without also updating go.mod/go.sum? And how did that change pass CI? |
I checked those files out before I committed as I didn't think they were related to the changes I did. How can I re-generate them? Clean build and test doesn't seem too. |
Please take the vendor file change out. |
Removed the vendor file |
Thanks for the contribution! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: coolstang, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…pstream-release-1.17 Automated cherry pick of #9386: add c5a ec2 aws support
…pstream-release-1.16 Automated cherry pick of #9386: add c5a ec2 aws support
…of-#9386-upstream-release-1.16 Automated cherry pick of kubernetes#9386: add c5a ec2 aws support
…of-#9386-upstream-release-1.16 Automated cherry pick of kubernetes#9386: add c5a ec2 aws support
…of-#9386-upstream-release-1.16 Automated cherry pick of kubernetes#9386: add c5a ec2 aws support
Closes #9281