Update the service manifest for Docker

[hakman]

Updating based on latest Docker service manifest:
https://github.com/docker/docker-ce-packaging/blob/360f755c768ebb06c9974705674302098bb9c398/systemd/docker.service

This ended up being a bit bigger than expected, but mostly because a new version of github.com/blang/semver/v4 was needed to parse the docker version, which contains leading 0s.

Summary (with similar commit names):

• add cgroup related dependencies
• use "infinity" for LimitNOFILE and LimitNPROC for less accounting overhead
• remove workaround for old unsupported Docker versions
• remove workaround for socket activation on CentOS/RHEL distros
• rearrange manifest to match official manifest
• add containerd service dependency for newer Docker versions (with new semver as prerequisite)

[johngmyers]

Appears to also remove code for unsupported old docker versions and remove a RHEL workaround.

[hakman]

Appears to also remove code for unsupported old docker versions and remove a RHEL workaround.

That is the intent. The unsupported old docker versions were already removed and the RHEL workaround should no longer be needed.

[olemarkus]

/lgtm

[hakman]

/test pull-kops-e2e-kubernetes-aws

[hakman]

/test pull-kops-e2e-kubernetes-aws

[rifelpet]

overall this looks good to me. regarding the removed docker versions, is there any api validation that we should do there to alert users to upgrade if their manifest is still specifying an older docker version? or what exactly will the user experience be in that case?

[hakman]

@rifelpet The validation was introduced in a previous commit:

kops/pkg/apis/kops/validation/validation.go

Lines 1005 to 1013 in 39db604

	if config.Version != nil {
	if strings.HasPrefix(*config.Version, "1.1") {
	allErrs = append(allErrs, field.Invalid(fldPath.Child("version"), config.Version,
	"version is no longer available: https://www.docker.com/blog/changes-dockerproject-org-apt-yum-repositories/"))
	} else {
	valid := []string{"17.03.2", "17.09.0", "18.03.1", "18.06.1", "18.06.2", "18.06.3", "18.09.3", "18.09.9", "19.03.4", "19.03.8", "19.03.11"}
	allErrs = append(allErrs, IsValidValue(fldPath.Child("version"), config.Version, valid)...)
	}
	}

[rifelpet]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rifelpet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment