Fix where etcd-cluster-spec is writen when etcd's BackupStore is defined -v2 #9474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/api
approved
rdrgmnzs
force-pushed
the
fix-non-standard-backupStore-v2
branch
from
0a521ca
to
dcbd81f
Compare
rdrgmnzs
force-pushed
the
fix-non-standard-backupStore-v2
branch
from
dcbd81f
to
627b715
Compare
|
Thanks so much @rdrgmnzs - both for finding & fixing and for tweaking to try the other approach. I think this version is clearer, so I think we should get this one in! /approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, rdrgmnzs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Jul 2, 2020
k8s-ci-robot
added a commit
that referenced
this pull request
Jul 2, 2020
Automated cherry pick of #9474 onto release-1.18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a user defines a non-standard backupStore location, such as:
backupStore: s3://my-bucket/etcdBackup/my-cluster.local
the etcd-cluster-spec is still written to the default location and ignores the store set in backupStore. This in turn causes etcd-manager to not start etcd since it still honors the user defined backupStore location.
This is an alternative to #9319
/assign @justinsb