Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix verify-terraform in release-1.18 branch #9504

Merged
merged 2 commits into from
Jul 6, 2020
Merged

Fix verify-terraform in release-1.18 branch #9504

merged 2 commits into from
Jul 6, 2020

Conversation

johngmyers
Copy link
Member

Cherry-pick 5499402 from #9340
Also cherry-pick #9399

@rifelpet @johngmyers
dont allocate tty in docker run, fixes prow jobs
e05cc1d
@rifelpet @johngmyers
Cache terraform's providers between tests
8da6295 
The provider binaries are in the hundreds of MBs and by defaulta are redownloaded into each integration tests' directory, this is a waste of bandwidth, time, and space.

TF supports specifying a provider cache directory [0] which will avoid redownloading them and storing them in multiple places, which should speed up the job time by a bit.

I was having trouble getting it to work with TF 0.12 so I bumped us up to the latest 0.13 beta (stable is scheduled for ~1 month from now)

[0] https://www.terraform.io/docs/configuration/providers.html#provider-plugin-cache
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jul 6, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 6, 2020
@johngmyers johngmyers mentioned this pull request Jul 6, 2020
Merged
@johngmyers
Copy link
Member Author

/test verify-terraform

@k8s-ci-robot
Copy link
Contributor

@johngmyers: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-kops-bazel-build
  • /test pull-kops-bazel-test
  • /test pull-kops-e2e-kubernetes-aws-1-18
  • /test pull-kops-verify-bazel
  • /test pull-kops-verify-generated
  • /test pull-kops-verify-gomod
  • /test pull-kops-verify-boilerplate
  • /test pull-kops-verify-gofmt
  • /test pull-kops-verify-govet
  • /test pull-kops-verify-packages
  • /test pull-kops-verify-hashes
  • /test pull-kops-verify-terraform
  • /test pull-kops-verify

Use /test all to run the following jobs:

  • pull-kops-bazel-build
  • pull-kops-bazel-test
  • pull-kops-e2e-kubernetes-aws-1-18
  • pull-kops-verify-bazel
  • pull-kops-verify-generated
  • pull-kops-verify-gomod
  • pull-kops-verify-boilerplate
  • pull-kops-verify-gofmt
  • pull-kops-verify-govet
  • pull-kops-verify-packages

In response to this:

/test verify-terraform

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@johngmyers
Copy link
Member Author

/test pull-kops-verify-terraform

@johngmyers johngmyers changed the title Fix verify-terraform Fix verify-terraform in release-1.18 branch Jul 6, 2020
@johngmyers
Copy link
Member Author

/assign @rifelpet

@rifelpet
Copy link
Member

rifelpet commented Jul 6, 2020

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit a3b098e into kubernetes:release-1.18 Jul 6, 2020
@johngmyers johngmyers deleted the fix-terraform branch July 6, 2020 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman Awaiting requested review from hakman

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johngmyers @k8s-ci-robot @rifelpet