Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go.mod's gazelle to 0.21.1 #9511

Closed
wants to merge 1 commit into from

Conversation

rifelpet
Copy link
Member

@rifelpet rifelpet commented Jul 7, 2020

I had updated the gazelle version in WORKSPACE earlier but it turns out it is defined twice, and the hack/update-bazel.sh script uses the go module copy, so this updates the go.mod instance to match the WORKSPACE instance.

03e620b#diff-09498dbadf45966909850dc8a47ebb13L16-L23

I had updated the gazelle version in WORKSPACE earlier but it turns out it is defined twice, and the hack/update-bazel.sh script uses the go module copy, so this updates the go.mod instance to match the WORKSPACE instance.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2020
@k8s-ci-robot
Copy link
Contributor

@rifelpet: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kops-verify-bazel 4332cb8 link /test pull-kops-verify-bazel
pull-kops-bazel-test 4332cb8 link /test pull-kops-bazel-test
pull-kops-e2e-kubernetes-aws 4332cb8 link /test pull-kops-e2e-kubernetes-aws
pull-kops-verify-gomod 4332cb8 link /test pull-kops-verify-gomod
pull-kops-bazel-build 4332cb8 link /test pull-kops-bazel-build

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link
Contributor

@rifelpet: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 7, 2020
@rifelpet
Copy link
Member Author

rifelpet commented Jul 7, 2020

@hakman determined this depends on rules_go 0.23 which will require larger work around arch-specific builds, so we may defer until k/k upgrades to rules_go to update this as well.
/close

@k8s-ci-robot
Copy link
Contributor

@rifelpet: Closed this PR.

In response to this:

@hakman determined this depends on rules_go 0.23 which will require larger work around arch-specific builds, so we may defer until k/k upgrades to rules_go to update this as well.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rifelpet rifelpet deleted the gazelle-update-0211 branch October 29, 2020 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants