Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stable names for GH workflow jobs #9552

Merged
merged 5 commits into from
Jul 13, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Jul 12, 2020

We will need to pass the job names to Tide to make them blocking, so stable names would be required.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 12, 2020
- name: make nodeup examples test
working-directory: ${{ env.GOPATH }}/src/k8s.io/kops
run: |
make nodeup examples test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably skip making nodeup on MacOS.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Done.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why we only build nodeup and not all ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this is just historical about the way these tests were introduced (they're still fairly new); I suspect we were just trying to replace tests in travis.

From that point of view I really like splitting out the tests explicitly. What we really want on macos is coverage of the kops CLI (I don't think we want nodeup tests to run on macos; there's a case for windows in the future but I don't know of anyone trying to get kubelet to run on macos)

For linux, I think trying everything seems reasonable! We should probably be trending towards running tests in bazel, as more and more of our release pipeline is using bazel (I have some exciting news on this front for our next office hours :-) )

I think it's fine to rearrange what these do a bit in a separate PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to that :).

@johngmyers
Copy link
Member

This removes Go 1.13. Is that because it's currently redundant with the Prow jobs and we expect to drop it as a requirement when we move Prow to 1.14?

@hakman
Copy link
Member Author

hakman commented Jul 12, 2020

This removes Go 1.13. Is that because it's currently redundant with the Prow jobs and we expect to drop it as a requirement when we move Prow to 1.14?

Yes. Also, when Go 1.15 is released we can add an optional build-next job.

@rifelpet
Copy link
Member

this looks good to me. I agree we can have optional jobs for the next or previous go versions. I know i've asked this before, but to confirm here, are we safe to merge this with prow configured as-is and will it affect other open PRs? and what will the rollout to enforce these jobs look like exactly?

@hakman
Copy link
Member Author

hakman commented Jul 13, 2020

@rifelpet open PRs would behave like current release branches, expecting these tests, but will not block for now.
Having stable names, means that we can backport these to release branches also and satisfy Prow and Tide requirements.
Once we are happy with how things work, we can see what should be done to make them blocking and remove the equivalent TravisCI jobs.

@justinsb
Copy link
Member

/approve
/lgtm

Github testing isn't entirely happy, so this is also a nice test of whether we're going to break other PRs (I think!)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 13, 2020
@hakman
Copy link
Member Author

hakman commented Jul 13, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 1c12ce3 into kubernetes:master Jul 13, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 13, 2020
@hakman hakman deleted the github-workflow-v2 branch July 13, 2020 05:08
@rifelpet rifelpet mentioned this pull request Jul 14, 2020
k8s-ci-robot added a commit that referenced this pull request Jul 14, 2020
…pstream-release-1.18

Automated cherry pick of #9552: Use stable names for GH workflow jobs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants