Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer nodes with "master" role for Calico Typha pods #9609

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Prefer nodes with "master" role for Calico Typha pods #9609

merged 1 commit into from
Jul 23, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Jul 22, 2020

Fixes #9608
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 22, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/addons approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 22, 2020
@hakman
Copy link
Member Author

hakman commented Jul 22, 2020

/cc @KashifSaadat

@gjtempleton
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2020
@gjtempleton
Copy link
Member

/retest

@hakman
Copy link
Member Author

hakman commented Jul 22, 2020

Thanks @gjtempleton :)

@rifelpet
Copy link
Member

/lgtm
as well.

@hakman
Copy link
Member Author

hakman commented Jul 23, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5a1757e into kubernetes:master Jul 23, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 23, 2020
@hakman hakman deleted the calico-typha-affinity branch July 23, 2020 03:29
@hakman hakman mentioned this pull request Jul 23, 2020
Merged
k8s-ci-robot added a commit that referenced this pull request Jul 23, 2020
@k8s-ci-robot
Merge pull request #9611 from hakman/automated-cherry-pick-of-#9609-u…
a48d9a2 
…pstream-release-1.18

Automated cherry pick of #9609: Prefer nodes with "master" role for Calico Typha pods
@hakman hakman mentioned this pull request Aug 1, 2020
Merged
@tmjd
Copy link
Contributor

tmjd commented Aug 18, 2020

What is the use case for pushing Typha toward nodes with the "master" role?

@ozdanborne ozdanborne mentioned this pull request Aug 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjtempleton gjtempleton Awaiting requested review from gjtempleton

@johngmyers johngmyers Awaiting requested review from johngmyers

@KashifSaadat KashifSaadat Awaiting requested review from KashifSaadat

Assignees

@rifelpet rifelpet

@gjtempleton gjtempleton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

Calico's Typha pods should prefer to run on masters, but tolerate running elsewhere
5 participants
@hakman @k8s-ci-robot @gjtempleton @rifelpet @tmjd