Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use /etc/os-release to identify the distribution #9766

Merged
merged 7 commits into from Aug 18, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Aug 16, 2020

All supported distributions have the /etc/os-release file describing the distro info:
http://0pointer.de/blog/projects/os-release

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 16, 2020
@justinsb
Copy link
Member

OK this is a good simplification. Pondering whether we should fallback to the existing logic for a period... how did you get the example os-release files that you use in the tests?

@hakman
Copy link
Member Author

hakman commented Aug 16, 2020

@justinsb I got the files from starting various VMs for the respective distros and copying the /etc/*-release files.

@hakman hakman force-pushed the distros branch 3 times, most recently from a37ede4 to 5e15bd3 Compare August 16, 2020 19:56
@hakman
Copy link
Member Author

hakman commented Aug 18, 2020

If a fallback is added, will be very hard to catch any corner cases.
The change should be verified quite easily in the distros periodic tests, but also there is enough time until 1.19 to address any feedback from users.

@johngmyers
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit ffe3b34 into kubernetes:master Aug 18, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 18, 2020
@hakman hakman deleted the distros branch August 18, 2020 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants