Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove force_tcp flag for nodelocalcache dot zone #9917

Merged

Conversation

astrikos
Copy link
Contributor

This PR is proposing a change in the nodelocalcache confimap.
The change is removing the force_tcp flag from the . zone that handles all external DNS requests.
Using the current nodelocalcache configuration we have experienced increased latencies for our DNS requests that needs to go to our upstream DNS server (which in our case is AWS VPC's DNS servers).
Forcing all DNS communication go through TCP can lead to increased latency and slower DNS responses since a lot of upstream DNS servers are not optimized for TCP traffic.
An example is AWS's VPC DNS server that sending all the DNS traffic through TCP cause it to increase the latencies for this requests.
The kubernetes version has already changed this configmap to skip force_tcp flag for the . zone, so it might make sense to follow their example.

Reference https://github.com/kubernetes/kubernetes/blob/master/cluster/addons/dns/nodelocaldns/nodelocaldns.yaml#L100

Forcing all DNS communication go through TCP can lead to increased
latency and slower DNS responses since a lot of upstream DNS
servers are not optimized for TCP traffic.
An example is AWS's VPC DNS server that sending all the DNS traffic
through TCP cause it to increase the latencies for this requests.
The kubernetes version has already changed this configmap to skip
force_tcp flag for the . zone, so it makes sense to follow their
example.
Reference https://github.com/kubernetes/kubernetes/blob/master/cluster/addons/dns/nodelocaldns/nodelocaldns.yaml#L100
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 11, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @astrikos!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 11, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @astrikos. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/addons labels Sep 11, 2020
@olemarkus
Copy link
Member

/ok-to-test

Are you able to sign the CLA?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 11, 2020
@astrikos
Copy link
Contributor Author

astrikos commented Sep 11, 2020

Are you able to sign the CLA?

I signed it

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 11, 2020
@astrikos
Copy link
Contributor Author

/assign @rifelpet

@olemarkus
Copy link
Member

/lgtm

Thanks for this!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2020
@hakman
Copy link
Member

hakman commented Sep 11, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astrikos, hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit bafdacd into kubernetes:master Sep 11, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Sep 11, 2020
@astrikos astrikos deleted the astrikos/RemoveForceTCPFromDot branch September 15, 2020 18:37
k8s-ci-robot added a commit that referenced this pull request Oct 16, 2020
…17-origin-release-1.18

Automated cherry pick of #9917: Remove force_tcp flag for nodelocalcache dot zone
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants