Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kube-system psp to system:nodes #9941

Merged
merged 2 commits into from Sep 15, 2020
Merged

Conversation

zetaab
Copy link
Member

@zetaab zetaab commented Sep 15, 2020

fixes #9937

This is quite good page to read through https://octetz.com/docs/2019/2019-10-12-static-pods/

When we are deploying apiserver, controller-manager, scheduler, etcds with static pods. It means that those are running in docker and we cannot shutdown those using kubernetes api. However, when kubelet will try to add those "mirror pods" to kubernetes API the PSPs are applied. Kubelet cannot add these pods to K8s api without this permission

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 15, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2020
@olemarkus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2020
@zetaab
Copy link
Member Author

zetaab commented Sep 15, 2020

/test pull-kops-verify-gomod

@k8s-ci-robot k8s-ci-robot merged commit 530d162 into kubernetes:master Sep 15, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Sep 15, 2020
@zetaab zetaab deleted the fixpsp branch September 15, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

static pods not visible in kubectl get pods
3 participants