Move openapi proto parsing and indexing #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
mbohlool
suggested changes
Aug 31, 2017
pkg/util/proto/doc.go
Outdated
| limitations under the License. | ||
| */ | ||
|
|
||
| // Package openapi is a collection of libraries for fetching the openapi spec |
There was a problem hiding this comment.
package proto. Also it does not fetch OpenAPI spec, right? only parsing and indexing.
pkg/util/proto/document.go
Outdated
| return fmt.Errorf("SchemaError(%v): %v", path, err) | ||
| } | ||
|
|
||
| func VendorExtensionToMap(e []*openapi_v2.NamedAny) map[string]interface{} { |
There was a problem hiding this comment.
godoc on all public methods please.
pkg/util/proto/testing/gvk.go
Outdated
| "k8s.io/kube-openapi/pkg/util/proto" | ||
| ) | ||
|
|
||
| // groupVersionKindExtensionKey is the key used to lookup the |
There was a problem hiding this comment.
We should not have groupVersionKindExtensionKey here. The extension is kubernetes specific. I suggest you make it configurable somehow and set it in the importer of this code.
There was a problem hiding this comment.
Never mind, This is in test code. It is fine. nit: I would name it something like testExtensionKey and add it to the comment that only for testing we use some kubernetes spec that has this key.
|
Also please squash all commits into one. |
|
Updated. Squashed. Cut the test swagger to 10% size. |
kubectl OpenAPI bazel updates Print a newline after ginkgo tests so the test infra doesn't think that they fail Fixes #45279 Make OpenAPI GVK and Action extensions all lower-case Get cmd uses print-column extn from Openapi schema Get command now uses metadata x-kubernetes-print-columns, if present, in Openapi schema to format output for a resource. This functionality is guarded by a boolean flag 'use-openapi-print-columns'. manually fix kubectl openapi unit test openapi: Fetch protobuf rather than Json This is much faster. openapi: refactor into more generic structure Refactor the openapi schema to be a more generic structure that can be "visited" to get more specific types. openapi: Remove cache mechanism The cache will be removed and replaced with HTTP Etag caching instead. This patch is simply removing the existing mechanism. Revert "Merge pull request #47353 from apelisse/http-cache" This reverts commit fc89743dca6b563063b74728c3b28100cf674d9d, reversing changes made to 29ab38e898988c36e2de34f77fa33be556eb21bd. Autogenerate BUILD files Use buildozer to remove deprecated automanaged tags Use buildozer to delete licenses() rules except under third_party/ openapi: Move Fakes to testing package openapi: Add validation logic This allows validation of a yaml/json object against an openapi schema. A lot more testing would be needed to validate the logic, and also this is not plumbed in, so it can't be used by kubectl yet. Validate against OpenAPI schema (if available) openapi: Use "group" to look for resources openapi: Handle properly empty/null fileds openapi-validation: Handle List special case openapi validation: Ignore unknown types This follows the exact same logic as swagger. openapi: Change reference to be first-class References in the openapi are currently completely hidden from the model, and just passed through as we walk the tree. The problem is that they can have a different description and more importantly, different extensions. Change them to be first-class citizen, and fully part of the model. It means that visitors have to implement one more function and decide if something specific should be done with references. Validation is updated to just completely ignore them and passthrough (like it was done before). update pkg to not depend on other k8s repo
|
Ideally we would really like to test against the full swagger ( |
The openapi spec is not sync with main repo. We should not enforce it here. |
sgtm |
mbohlool
approved these changes
Sep 1, 2017
|
LGTM with assumption that this code is already code review-ed in the main repo. Thanks. |
This was referenced Sep 1, 2017
k8s-ci-robot
added
the
lgtm
k8s-github-robot
pushed a commit
to kubernetes/kubernetes
that referenced
this pull request
Sep 5, 2017
Automatic merge from submit-queue (batch tested with PRs 51739, 51762) Update vendor kube-openapi Update vendor to pick up some change in kube-openapi. The goal is to move some generic openapi parsing and indexing code to kube-openapi repo. Update the places that using it. #51321 will depend on this. fixes: #51822 kubernetes/kube-openapi#10 is the PR to move stuff to kube-openapi repo. ```release-note NONE ``` /assign @apelisse
k8s-github-robot
pushed a commit
to kubernetes/kubernetes
that referenced
this pull request
Sep 8, 2017
sttts
pushed a commit
to sttts/kube-openapi
that referenced
this pull request
Nov 5, 2020
migrate to travis and codecov
sttts
pushed a commit
to sttts/kube-openapi
that referenced
this pull request
Nov 5, 2020
sttts
pushed a commit
to sttts/kube-openapi
that referenced
this pull request
Nov 5, 2020
* fix kubernetes#10 - add error factor must be positive * fixed UT for new message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move openapi proto parsing and indexing from main repo to this repo.
The code includes parsing and indexing logic.
They are NOT depend on any other k8s repo.
/assign @mbohlool @apelisse