-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use gengo/v2 in kube-openapi #458
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
d1213fd
Commit latest integration results
thockin ffcc404
Use our own sets pkg instead of gengo
thockin bdea997
Convert imports to gengo/v2
thockin ab79d75
Don't auto-set the Go header file flag
thockin a5de500
Fix kube-openapi wrt gengo/v2
thockin 5fef66a
Rename DefaultPackage to SimplePackage (gengo/v2)
thockin f82efc8
Drop `gengo/v2/generator.Packages` type
thockin 007cebb
Rename `gengo/v2/generator.Package` -> `Target`
thockin 4079daf
Rename gengo/v2 DefaultGen -> GolangGenerator
thockin 4946e68
Type-assert gengo CustomArgs blindly
thockin 39f9127
gengo/v2 moves the OutputBase flag to each tool
thockin ce262fb
Rename output-package -> output-pkg (gengo/v2)
thockin 48882fa
genego/v2 moves OutputFileBase flag to each tool
thockin 13a77a3
gengo/v2 moves go-header-file flag to each tool
thockin ee2c702
Kill gengo WithoutDefaultFlagParsing (gone in v2)
thockin 07de3d4
Get rid of InputDirs flag
thockin f147b07
ParseSymbolReference is no longer exported
thockin c6b9085
Get rid of gengo CustomArgs (gone in v2)
thockin 66f3980
The gengo "args" package is gone
thockin c91b59f
Gengo utils moved
thockin cb8c818
GolangGenerator -> GoGenerator
thockin b9a9bc3
Run go get k8s.io/gengo/v2
thockin 571c24b
Fix pkg/generators/openapi_test w/ packagestest
thockin 9f9049d
Fix ./test/integration for gengo/v2
thockin File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: use the
c.ReportFilename
current field value (defaulted inNew()
) rather than stomping a hard-coded string-
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in next push