Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2: change metrics port to 8080, telemetry port to 8081 #1005

Merged
merged 1 commit into from Jan 31, 2020
Merged

v2: change metrics port to 8080, telemetry port to 8081 #1005

merged 1 commit into from Jan 31, 2020

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Dec 13, 2019

Signed-off-by: yeya24 yb532204897@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #976

@yeya24
change metrics port to 8080, telemetry port to 8081
53af563 
Signed-off-by: yeya24 <yb532204897@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 13, 2019
lilic
lilic reviewed Dec 16, 2019
View reviewed changes
Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @brancz any other places we need to change this?

/hold
until the next release

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2019
@tariq1890 tariq1890 changed the title change metrics port to 8080, telemetry port to 8081 v2: change metrics port to 8080, telemetry port to 8081 Dec 17, 2019
@tariq1890 tariq1890 added the v2 version 2 label Dec 17, 2019
lilic
lilic approved these changes Jan 31, 2020
View reviewed changes
Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2020
@lilic
Copy link
Member

lilic commented Jan 31, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiliC, yeya24

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0ff33c2 into kubernetes:master Jan 31, 2020
@tlereste tlereste mentioned this pull request Feb 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilic lilic lilic approved these changes

@tariq1890 tariq1890 Awaiting requested review from tariq1890

Assignees

@lilic lilic

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. v2 version 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v2: Use same ports in all cases
4 participants
@yeya24 @lilic @k8s-ci-robot @tariq1890