Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename kube_pod_deleted to kube_pod_deletion_timestamp #1079

Merged
merged 1 commit into from Feb 26, 2020

Conversation

olivierlemasle
Copy link
Member

What this PR does / why we need it:

Rename kube_pod_deleted to kube_pod_deletion_timestamp, to fix an inconsistency.

Which issue(s) this PR fixes :
Fixes #1068

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 24, 2020
@brancz
Copy link
Member

brancz commented Feb 26, 2020

/lgtm
/approve

Thanks a lot for taking care of this!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, olivierlemasle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2020
@k8s-ci-robot k8s-ci-robot merged commit 89ede10 into kubernetes:master Feb 26, 2020
@olivierlemasle olivierlemasle deleted the fix-1068 branch February 26, 2020 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kube_pod_deleted should be called kube_pod_deletion_timestamp
3 participants