Fix various CI issues #1117
Merged
Fix various CI issues #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
size/S
This was most likely due to an issue on travis side, things are back to normal now. |
brancz
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brancz, lilic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
|
Thanks @brancz |
wtan825
pushed a commit
to wtan825/kube-state-metrics
that referenced
this pull request
Jul 20, 2020
Fix various CI issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
CI caught a violation of the label name being
nodeName(camelCase) rather than snake_case, however, this is actually a case of another violation, which is the kubernetes instrumentation guideline says, that this label should have always beennodeto begin with, to allow for joining without label_replace. This metric is experimental anyways, so we're free to change this.We're not sure yet why PR CI didn't catch this.Travis CI not reporting seems to have magically fixed itself (possibly by either @lilic or myself logging in to Travis refreshing something?).
To get CI into a working state, I fixed the remaining issues as well.
@lilic @tariq1890