Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new pod metric kube_pod_container_state_started #1183

Merged
merged 4 commits into from Jul 28, 2020

Conversation

vikkyomkar
Copy link
Contributor

What this PR does / why we need it:
This adds a new metric kube_pod_container_state_started under POD metrics

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes #1167

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 26, 2020
@brancz
Copy link
Member

brancz commented Jul 27, 2020

Could you increase the number of expected metrics in the benchmark test? We model the benchmark around the Pod collector and test for correctness as well. You just need to increase the 56 metrics to 57.

@vikkyomkar
Copy link
Contributor Author

Could you increase the number of expected metrics in the benchmark test? We model the benchmark around the Pod collector and test for correctness as well. You just need to increase the 56 metrics to 57.

Thanks for the hint @brancz
Now this PR is ready for review

Copy link
Member

@brancz brancz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, vikkyomkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2020
@k8s-ci-robot k8s-ci-robot merged commit e43aaa6 into kubernetes:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing container start time metric kube_pod_container_state_started
3 participants