Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump client-go and friends to v0.20 (kubernetes v1.20) #1328

Merged
merged 5 commits into from
Jan 4, 2021

Conversation

lilic
Copy link
Member

@lilic lilic commented Dec 16, 2020

Bumping all the things to k8s v1.20.

cc @brancz @tariq1890 PTAL, thanks!

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 16, 2020
@lilic
Copy link
Member Author

lilic commented Dec 16, 2020

Doing it towards the release-2.0 branch and will bring then to master as well. I thought would be good to have this release be up to date with v1.20.

@tariq1890
Copy link
Contributor

Any reason why we revendored? I may have missed some previous discussion I think

@lilic
Copy link
Member Author

lilic commented Jan 4, 2021

@tariq1890 this is the 2.0 branch, the removal of the vendor directory only happened in master. Unless you are referring to something else?

Copy link
Member

@brancz brancz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, lilic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2e356cd into kubernetes:release-2.0 Jan 4, 2021
@lilic lilic deleted the bump-1.20 branch January 4, 2021 09:47
mayankshah1607 pushed a commit to mayankshah1607/kube-state-metrics that referenced this pull request Feb 21, 2021
Signed-off-by: Mayank Shah <mayankshah1614@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants