Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix labels-metric-allow-list documentation #1404

Merged

Conversation

Mikulas
Copy link
Contributor

@Mikulas Mikulas commented Mar 3, 2021

The parser defined in types.go does not expect quotes
https://github.com/kubernetes/kube-state-metrics/blob/release-2.0/pkg/options/types.go#L136-L140
https://github.com/kubernetes/kube-state-metrics/blob/release-2.0/pkg/options/types_test.go#L168

This issue is unfortunate because ksm does parse the quoted syntax fine but the labels never match (eg label is foo but ksm matches against "foo"). As such this is pretty important patch for the 2.0 release. Further improvements could be made but this documentation fix is the bare minimum.

Targeting release-2.0 (or should this be based on master and backported afterwards?)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 3, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 3, 2021
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 3, 2021
@Mikulas
Copy link
Contributor Author

Mikulas commented Mar 3, 2021

/kind bug
/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Mar 3, 2021
@Mikulas
Copy link
Contributor Author

Mikulas commented Mar 3, 2021

/label release-2.0

@k8s-ci-robot
Copy link
Contributor

@Mikulas: The label(s) /label release-2.0 cannot be applied. These labels are supported: api-review, community/discussion, community/maintenance, community/question, cuj/build-train-deploy, cuj/multi-user, platform/aws, platform/azure, platform/gcp, platform/minikube, platform/other, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash

In response to this:

/label release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@brancz
Copy link
Member

brancz commented Mar 4, 2021

Thank you! lgtm 👍

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, Mikulas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2021
@k8s-ci-robot k8s-ci-robot merged commit 323a841 into kubernetes:release-2.0 Mar 4, 2021
@Mikulas Mikulas deleted the docs-label-allowlist-fix branch March 4, 2021 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants