Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

capture start time for containers in terminated state #1519

Merged
merged 1 commit into from
Aug 9, 2021
Merged

capture start time for containers in terminated state #1519

merged 1 commit into from
Aug 9, 2021

Conversation

harjas27
Copy link
Contributor

@harjas27 harjas27 commented Jul 1, 2021

What this PR does / why we need it:
In reference to the metric:

kube_pod_container_state_started
Start time in unix timestamp for a pod container

The metric is collected only for the containers which are in "Running" state and not when the state of the container is "Terminated". The metric can be collected for the "Terminated" containers as well, this PR adds the logic for the same.
This will fix the issue where this metric is missing for pods which run for a short time and the containers are terminated after completion of the job/task

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1467

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 1, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @harjas27!

It looks like this is your first PR to kubernetes/kube-state-metrics 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-state-metrics has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot requested review from brancz and mrueg July 1, 2021 17:30
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 1, 2021
@mrueg
Copy link
Member

mrueg commented Aug 9, 2021 •
edited

/approve

Thanks for your contribution. Waiting for a second maintainer to approve.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2021
dgrisonnet
dgrisonnet reviewed Aug 9, 2021
View reviewed changes
Copy link
Member

@dgrisonnet dgrisonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind also adding the start time for the Waiting status so that we have it for all the status?

@harjas27
Copy link
Contributor Author

harjas27 commented Aug 9, 2021 •
edited

@dgrisonnet there is no field for StartedAt in the ContainerStateWaiting struct:
https://github.com/kubernetes/api/blob/499b6f90564cff48dc1fba56d974de2e5ec98bb4/core/v1/types.go#L2441-L2448

@dgrisonnet
Copy link
Member

Ah, indeed I thought it was common to all status.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, harjas27, mrueg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 16e8f54 into kubernetes:master Aug 9, 2021
mrueg added a commit to mrueg/kube-state-metrics that referenced this pull request Aug 19, 2021
@mrueg
*: Cut v2.2.0 release
6194092 
* [FEATURE] Add --use-apiserver-cache flag to set resourceVersion=0 for ListWatch requests kubernetes#1548
* [FEATURE] Introduce metrics for Kubernetes object annotations kubernetes#1468
* [FEATURE] Introduce start time metric for containers in terminated state kubernetes#1519
* [FEATURE] Introduce metrics for cronjob job history limits kubernetes#1535
* [FEATURE] Add system_uuid dimension to kube_node_info metric kubernetes#1535
* [FEATURE] Add available replica metric for statefulsets kubernetes#1532
* [FEATURE] Add ready replica metric for deployments kubernetes#1534
* [CHANGE]  Update go clients for Kubernetes to support 1.22 kubernetes#1545
* [CHANGE]  Use new promlint package and update prometheus cli to 2.28.1 kubernetes#1531
@mrueg mrueg mentioned this pull request Aug 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrisonnet dgrisonnet dgrisonnet left review comments

@brancz brancz Awaiting requested review from brancz

@mrueg mrueg Awaiting requested review from mrueg

Assignees

@dgrisonnet dgrisonnet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kube_pod_container_state_started is not returned for some pods
4 participants
@harjas27 @k8s-ci-robot @mrueg @dgrisonnet