Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create opt-in kube_persistentvolume_csi_attributes metric #2133

Conversation

machadovilaca
Copy link
Contributor

@machadovilaca machadovilaca commented Aug 1, 2023

What this PR does / why we need it:

This PR creates a new opt-in kube_persistentvolume_csi_attributes metric

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)

It doesn't affect it since the metric is opt-in.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 1, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @machadovilaca!

It looks like this is your first PR to kubernetes/kube-state-metrics 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-state-metrics has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 1, 2023
@dashpole
Copy link

/assign @dgrisonnet
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 10, 2023
@mrueg
Copy link
Member

mrueg commented Aug 11, 2023

Can you update https://github.com/kubernetes/kube-state-metrics/blob/main/docs/persistentvolume-metrics.md to include the new attribute as well?

internal/store/persistentvolume.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 29, 2023
@machadovilaca machadovilaca force-pushed the add-csi-volume-attributes-to-pv-info-metric branch from c7b0c08 to 0eee653 Compare October 24, 2023 11:32
@machadovilaca machadovilaca changed the title feat: Add CSI volume attributes to PV info metric feat: create opt-in kube_persistentvolume_csi_attributes metric Oct 24, 2023
@machadovilaca machadovilaca force-pushed the add-csi-volume-attributes-to-pv-info-metric branch from 0eee653 to 23e108a Compare October 24, 2023 11:34
@machadovilaca
Copy link
Contributor Author

machadovilaca commented Oct 24, 2023

@dgrisonnet created a new opt-in metric, maybe this is enough to avoid very specific information

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2023
@machadovilaca machadovilaca force-pushed the add-csi-volume-attributes-to-pv-info-metric branch from 23e108a to 2866bc8 Compare November 21, 2023 10:54
Signed-off-by: João Vilaça <jvilaca@redhat.com>
@machadovilaca machadovilaca force-pushed the add-csi-volume-attributes-to-pv-info-metric branch from 2866bc8 to e09df21 Compare November 23, 2023 12:15
Copy link
Member

@dgrisonnet dgrisonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, machadovilaca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit 240cffd into kubernetes:main Nov 23, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants