-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(customresourcestate): allow string Array for labelFromPath #2150
Conversation
|
This issue is currently awaiting triage. If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @adberger! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: adberger The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -192,7 +192,7 @@ func newCompiledMetric(m Metric) (compiledMetric, error) { | |||
} | |||
valueFromPath, err := compilePath(m.StateSet.ValueFrom) | |||
if err != nil { | |||
return nil, fmt.Errorf("each.gauge.valueFrom: %w", err) | |||
return nil, fmt.Errorf("each.stateSet.valueFrom: %w", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
Seems to already work: #2151 |
@adberger do you want to create a PR for #2150 (comment) I think it'd be good to fix the misleading error message. |
@mrueg done. |
What this PR does / why we need it:
Some CRs expose information as Arrays of type String and not Array of type Maps (e.g. namespaces in https://capsule.clastix.io/docs/general/crds-apis/#tenantstatus).
AFAIK it's currently not possible to add these as labels to a metric, this PR should fix this.
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
If I understand this correctly, the cardinality should not increase.
Which issue(s) this PR fixes
#2149