Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(customresourcestate): allow string Array for labelFromPath #2150

Closed
wants to merge 1 commit into from
Closed

feat(customresourcestate): allow string Array for labelFromPath #2150

wants to merge 1 commit into from

Conversation

adberger
Copy link
Contributor

What this PR does / why we need it:

Some CRs expose information as Arrays of type String and not Array of type Maps (e.g. namespaces in https://capsule.clastix.io/docs/general/crds-apis/#tenantstatus).
AFAIK it's currently not possible to add these as labels to a metric, this PR should fix this.

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)

If I understand this correctly, the cardinality should not increase.

Which issue(s) this PR fixes

#2149

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 17, 2023 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: adberger / name: Adrian Berger (aef68f9)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 17, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Aug 17, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @adberger!

It looks like this is your first PR to kubernetes/kube-state-metrics 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-state-metrics has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adberger
Once this PR has been reviewed and has the lgtm label, please assign rexagod for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 17, 2023
mrueg
mrueg reviewed Aug 21, 2023
View reviewed changes
pkg/customresourcestate/registry_factory.go
@@ -192,7 +192,7 @@ func newCompiledMetric(m Metric) (compiledMetric, error) {
}
valueFromPath, err := compilePath(m.StateSet.ValueFrom)
if err != nil {
return nil, fmt.Errorf("each.gauge.valueFrom: %w", err)
return nil, fmt.Errorf("each.stateSet.valueFrom: %w", err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@adberger
Copy link
Contributor Author

Seems to already work: #2151

@adberger adberger closed this Aug 22, 2023
@mrueg
Copy link
Member

mrueg commented Aug 22, 2023

@adberger do you want to create a PR for #2150 (comment) I think it'd be good to fix the misleading error message.

@adberger adberger mentioned this pull request Aug 22, 2023
Merged
@adberger
Copy link
Contributor Author

@adberger do you want to create a PR for #2150 (comment) I think it'd be good to fix the misleading error message.

@mrueg done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrueg mrueg mrueg left review comments

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

@rexagod rexagod Awaiting requested review from rexagod

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adberger @k8s-ci-robot @mrueg