Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Cut v2.12.0 #2335

Merged
merged 1 commit into from
Apr 2, 2024
Merged

chore: Cut v2.12.0 #2335

merged 1 commit into from
Apr 2, 2024

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented Mar 7, 2024 •
edited

Blocked by #2317.

  • Update main to v0.29.2 before merging this.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 7, 2024
@dashpole
Copy link

dashpole commented Mar 7, 2024

/triage accepted
/assign @dgrisonnet

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 7, 2024
This was referenced Mar 7, 2024
Closed
Closed
@liangyuanpeng liangyuanpeng mentioned this pull request Mar 14, 2024
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rexagod rexagod mentioned this pull request Apr 2, 2024
Merged
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 2, 2024
@rexagod rexagod changed the base branch from main to release-2.12 April 2, 2024 10:01
@rexagod
Copy link
Member Author

rexagod commented Apr 2, 2024

/cc @mrueg @dgrisonnet

@k8s-ci-robot k8s-ci-robot requested a review from mrueg April 2, 2024 10:06
@mrueg
Copy link
Member

mrueg commented Apr 2, 2024

/hold

/lgtm

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 2, 2024
@rexagod
Copy link
Member Author

rexagod commented Apr 2, 2024

I think I'll /lgtm this tomorrow as long as there are no changes requested here, to give some time to let this sink in.

dgrisonnet
dgrisonnet reviewed Apr 2, 2024
View reviewed changes
Copy link
Member

@dgrisonnet dgrisonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, mrueg, rexagod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dgrisonnet,mrueg,rexagod]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1e8b837 into kubernetes:release-2.12 Apr 2, 2024
12 checks passed
@CatherineF-dev CatherineF-dev mentioned this pull request Apr 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrisonnet dgrisonnet dgrisonnet left review comments

@logicalhan logicalhan Awaiting requested review from logicalhan

@mrueg mrueg Awaiting requested review from mrueg

Assignees

@mrueg mrueg

@dgrisonnet dgrisonnet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rexagod @dashpole @k8s-ci-robot @mrueg @dgrisonnet