Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use --track-unscheduled-pods to select unscheduled pods in Daemonset sharding #2388

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

fix: use --track-unscheduled-pods to select unscheduled pods in Daemonset sharding #2388

wants to merge 13 commits into from
+250 −125

Conversation

CatherineF-dev
Copy link
Contributor

@CatherineF-dev CatherineF-dev commented May 9, 2024 •
edited
Loading

What this PR does / why we need it:

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2353

Tested using minikube

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 9, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 9, 2024
@mrueg
Copy link
Member

mrueg commented May 15, 2024

Will this supersede #2373 ?

@CatherineF-dev
Copy link
Contributor Author

Will this supersede #2373 ?

Yes.

@dgrisonnet
Copy link
Member

/assign
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 16, 2024
mrueg
mrueg reviewed May 16, 2024
View reviewed changes
pkg/options/types.go Outdated Show resolved Hide resolved
@mrueg mrueg mentioned this pull request May 16, 2024
Closed
@mrueg
Copy link
Member

mrueg commented May 16, 2024

/hold
for others to review.
/lgtm

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2024
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 16, 2024
@mrueg mrueg mentioned this pull request May 16, 2024
Closed
@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 16, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2024
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 17, 2024
@CatherineF-dev
Copy link
Contributor Author

/lgtm to trigger tide

@CatherineF-dev CatherineF-dev mentioned this pull request May 18, 2024
Closed
logicalhan
logicalhan reviewed May 21, 2024
View reviewed changes
Copy link
Member

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests?

@diranged
Copy link

@logicalhan Can we just skip that for now? We've been waiting for 6 weeks to #2374 resolved, and we're having daily pain points with KSM right now in our environment. While I appreciate adding tests, we're literally removing code and making it simpler here.. can we bypass this and just get a fix in ASAP?

CatherineF-dev and others added 2 commits June 19, 2024 09:28
@CatherineF-dev @mrueg
Update jsonnet/kube-state-metrics/kube-state-metrics.libsonnet
fe547f7 
Co-authored-by: Manuel Rüger <manuel@rueg.eu>
@CatherineF-dev @mrueg
Update docs/developer/cli-arguments.md
ce0675a 
Co-authored-by: Manuel Rüger <manuel@rueg.eu>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 19, 2024
@CatherineF-dev
Copy link
Contributor Author

@mrueg need a review again. Rebased to HEAD.

@CatherineF-dev
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2024
@CatherineF-dev
Copy link
Contributor Author

/lgtm

@k8s-ci-robot
Copy link
Contributor

@CatherineF-dev: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CatherineF-dev, mrueg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LaikaN57
Copy link

tests?

@logicalhan Tests now implemented thanks to all of @CatherineF-dev's hard work 🙏 Looks like we are looking for review again now. Thanks!

dgrisonnet
dgrisonnet reviewed Jun 27, 2024
View reviewed changes
pkg/options/options.go Outdated Show resolved Hide resolved
dgrisonnet
dgrisonnet reviewed Jun 28, 2024
View reviewed changes
README.md.tpl Outdated Show resolved Hide resolved
pkg/options/types.go Outdated
Comment on lines 112 to 118
if fetchUnscheduledPods {
if string(*n) != "" {
klog.Warningf("spec.nodeName=%s will not be used, because --enable-unscheduled-pods-fetching is set", string(*n))
}
klog.InfoS("Using spec.nodeName= to select unscheduable pods without node")
return "spec.nodeName="
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels odd to handle this here since fetchUnscheduledPods is not related to the node object. I think we should take care of this scenario in the caller RunKubeStateMetrics

@CatherineF-dev CatherineF-dev changed the title fix: use --enable-unscheduled-pods-fetching to select unscheduled pods fix: use --track-unscheduled-pods to select unscheduled pods in DaemonsetSharding Jun 28, 2024
@CatherineF-dev CatherineF-dev changed the title fix: use --track-unscheduled-pods to select unscheduled pods in DaemonsetSharding fix: use --track-unscheduled-pods to select unscheduled pods in Daemonset sharding Jun 28, 2024
rexagod
rexagod requested changes Jul 2, 2024
View reviewed changes
Copy link
Member

@rexagod rexagod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL #2388 (comment).

@mrueg
Copy link
Member

mrueg commented Jul 15, 2024

Heads up: This is currently listed for the v2.13 milestone. In order to get a release out soon, I'll drop all open PRs by Wednesday from that milestone.

@CatherineF-dev
Copy link
Contributor Author

@rexagod have fixed the change request. Thx! Need a lgtm

@mrueg mrueg removed this from the v2.13.0 milestone Jul 17, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaikaN57 LaikaN57 LaikaN57 left review comments

@mrueg mrueg mrueg left review comments

@logicalhan logicalhan logicalhan left review comments

@dgrisonnet dgrisonnet dgrisonnet left review comments

@rexagod rexagod rexagod requested changes

Assignees

@mrueg mrueg

@dgrisonnet dgrisonnet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sharding with a deployment with '--resources=pods' and '--node=""' does not fetch pending pods
8 participants
@CatherineF-dev @mrueg @dgrisonnet @k8s-ci-robot @diranged @logicalhan @LaikaN57 @rexagod