Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add an example of joining the metrics in docs #539

Merged
merged 3 commits into from Sep 18, 2018
Merged

add an example of joining the metrics in docs #539

merged 3 commits into from Sep 18, 2018

Conversation

abinet
Copy link
Contributor

@abinet abinet commented Sep 14, 2018 •
edited by andyxning

This PR adds an example for joining the metrics as per discussion in #536

Fix #536

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 14, 2018
@abinet
Copy link
Contributor Author

abinet commented Sep 14, 2018

/assign @brancz

@abinet
Copy link
Contributor Author

abinet commented Sep 14, 2018

/check-cla

1 similar comment
@abinet
Copy link
Contributor Author

abinet commented Sep 14, 2018

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 14, 2018
@abinet
Copy link
Contributor Author

abinet commented Sep 14, 2018

/approve

andyxning
andyxning reviewed Sep 16, 2018
View reviewed changes
Documentation/README.md Outdated


## Join Metrics
When an additional, not provided by default label is needed a [Prometheus matching operator](https://prometheus.io/docs/prometheus/latest/querying/operators/#vector-matching)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/is needed a/is needed, a

andyxning
andyxning reviewed Sep 16, 2018
View reviewed changes
Documentation/README.md Outdated

## Join Metrics
When an additional, not provided by default label is needed a [Prometheus matching operator](https://prometheus.io/docs/prometheus/latest/querying/operators/#vector-matching)
can be used to extend metrics output.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/extend metrics output/extend single metric output

@andyxning
Copy link
Member

Others lgtm.

zouyee
zouyee reviewed Sep 17, 2018
View reviewed changes
Documentation/README.md Outdated
This example adds `label_release` to the set of default labels of the `kube_pod_status_ready` metric:

```
kube_pod_status_ready * on (namespace, pod) group_left(label_release) kube_pod_labels
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you like to add a more detailed description about prometheus query to describe the purpose?

@brancz
Copy link
Member

brancz commented Sep 18, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 18, 2018
@brancz
Copy link
Member

brancz commented Sep 18, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abinet, brancz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit cb9f20b into kubernetes:master Sep 18, 2018
@brancz
Copy link
Member

brancz commented Sep 18, 2018

Thanks for the contribution! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyxning andyxning andyxning left review comments

@zouyee zouyee zouyee left review comments

Assignees

@brancz brancz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@abinet @k8s-ci-robot @andyxning @brancz @zouyee